Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty vector layer reload() will never invalidate cache #60154

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: empty vector layer reload() will never invalidate cache #60154

wants to merge 3 commits into from

Conversation

hxbb00
Copy link
Contributor

@hxbb00 hxbb00 commented Jan 15, 2025

empty layer will never reload cache after the external program inserts the data

@hxbb00
fix: empty vector layer reload() will never invalidate cache
406e60e 
empty layer will never reload cache after the external program inserts the data
@github-actions github-actions bot added this to the 3.42.0 milestone Jan 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 435a37a)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 435a37a)

@rouault
Copy link
Contributor

rouault commented Jan 16, 2025

@elpaso might want to review this. I see the test you want to remove was added in d2c317a

@hxbb00
Copy link
Contributor Author

hxbb00 commented Jan 16, 2025

pull_60154_2025-01-16_14-15-43

troopa81
troopa81 reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@troopa81 troopa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding test?

src/core/vector/qgsvectorlayercache.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpaso elpaso elpaso left review comments

@troopa81 troopa81 troopa81 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.42.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hxbb00 @rouault @elpaso @troopa81